Skip to content

Release v1.9.6#611

Merged
kilbot merged 1 commit into
mainfrom
release/1.9.6
Jun 17, 2026
Merged

Release v1.9.6#611
kilbot merged 1 commit into
mainfrom
release/1.9.6

Conversation

@kilbot

@kilbot kilbot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Release train 1.9.6 (re-aligns app/electron/free/pro to a single version).

  • apps/main version → 1.9.6
  • apps/web → web-bundle v1.9.9 merge commit 3689a12 (rebuilt from this 1.9.6 source; jsDelivr @1.9)
  • apps/electron → current electron main tip aab0ecf (electron 1.9.6 bump + the nightly bump-submodules.yml will sync the bump commit)

User-facing: cash-drawer support (auto-open / Open Drawer button / per-printer connector across thermal/ESC-POS, Epson, PrintNode, cloud print), analytics over-fire fix, translations.

Merging creates the monorepo v1.9.6 release. Electron release is dispatched after this merges (its CI rebuilds from monorepo main).

Summary by CodeRabbit

  • Chores
    • Updated package version and internal dependencies to latest versions for improved stability and compatibility.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c099be8-e220-460d-85b5-a46c7fe867f8

📥 Commits

Reviewing files that changed from the base of the PR and between 43c885c and 4631103.

📒 Files selected for processing (3)
  • apps/electron
  • apps/main/package.json
  • apps/web
✅ Files skipped from review due to trivial changes (1)
  • apps/main/package.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/web
  • apps/electron

📝 Walkthrough

Walkthrough

The apps/electron and apps/web git submodule pointers are each advanced to new commit hashes, and the @wcpos/main package version in apps/main/package.json is bumped from 1.9.4 to 1.9.6.

Changes

Submodule and Version Bumps

Layer / File(s) Summary
Submodule pointers and package version
apps/electron, apps/web, apps/main/package.json
apps/electron submodule pointer advanced to aab0ecfd, apps/web submodule pointer advanced to 3689a12f, and @wcpos/main package version incremented from 1.9.4 to 1.9.6.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • wcpos/monorepo#523: Adds or changes tooling to update and stage the same apps/electron and apps/web submodule gitlinks that this PR advances.
  • wcpos/monorepo#553: Also advances the apps/electron submodule pointer, the same type of change made in this PR.

Poem

🐇 Hop, hop, a hash has changed,
The submodules neatly rearranged,
electron and web point anew,
The version ticks from .4 to .6 too,
A tiny leap, but perfectly staged! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Release v1.9.6' directly and accurately summarizes the main change—a version release bump across the monorepo affecting apps/main, apps/web, and apps/electron subprojects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/1.9.6

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployment Summary

Item Status
Preview URL https://wcpos--f8o2uez0ux.expo.app
E2E Tests ✅ Passed
Commit f9670a6

🔗 Quick Links


🤖 Updated by GitHub Actions

@github-actions

Copy link
Copy Markdown
Contributor

📊 Test Coverage Report

Package Statements Branches Functions Lines
@wcpos/core 🔴 23.1% 🔴 26.9% 🔴 22.3% 🔴 22.6%
@wcpos/components 🔴 24.6% 🔴 27.3% 🔴 16.8% 🔴 24.3%
@wcpos/database 🟡 60.2% 🔴 55.0% 🟡 62.7% 🔴 59.7%
@wcpos/hooks 🔴 52.4% 🔴 50.1% 🔴 45.0% 🔴 52.4%
@wcpos/utils 🔴 55.9% 🟡 61.5% 🟡 71.4% 🔴 53.8%
@wcpos/query 🟢 83.9% 🟡 76.9% 🟡 77.7% 🟢 84.0%
Average 🔴 50.0% 🔴 49.6% 🔴 49.3% 🔴 49.5%
Coverage Legend
  • 🟢 Good (≥80%)
  • 🟡 Moderate (60-79%)
  • 🔴 Needs improvement (<60%)
  • ⚪ No coverage data
--- 🤖 Updated by GitHub Actions • [View full report](https://github.com/wcpos/monorepo/actions/runs/27684772820)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43c885c13c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/electron
@kilbot

kilbot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Re: the Codex P1 on the apps/electron pin — the desktop release version is read from the electron repo's own package.json (require('./package.json').version in electron tag-and-release.yml), which is bumped to 1.9.6 in wcpos/electron#276 and merged before the Publish workflow is dispatched. The apps/electron submodule pin here is a reference that the nightly bump-submodules.yml syncs to the 1.9.6 electron commit (standard process, per the 1.9.4 release); I'll trigger that sync manually right after electron releases. Published desktop assets will be 1.9.6. Resolving.

@kilbot kilbot merged commit 4bc40de into main Jun 17, 2026
20 checks passed
@kilbot kilbot deleted the release/1.9.6 branch June 17, 2026 11:29
@wcpos-bot wcpos-bot Bot mentioned this pull request Jun 17, 2026
4 tasks
@wcpos-bot

wcpos-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Fix triage for the actionable review feedback:

Thread File Issue Decision Commit
discussion_r3427682743 electron apps/electron was pinned to Electron aab0ecf, whose @wcpos/app-electron package version is 1.9.5; release 1.9.6 needs an Electron commit with package version 1.9.6. Fixed on release/1.9.6; #611 had already merged before the fix landed on main, so follow-up PR #612 carries the fix into main. 29d4fd1

Excluded threads:

Thread Reason for skipping
None No unresolved review threads remained in the final GraphQL inventory.

Verification evidence:

  • Previous Electron pin aab0ecf: @wcpos/app-electron 1.9.5.
  • New Electron pin d876878: @wcpos/app-electron 1.9.6.
  • main...release/1.9.6 diff contains only apps/electron.
  • Final unresolved review-thread count for Release v1.9.6 #611: 0.
  • Local validation profile attempted: pnpm install, pnpm lint, pnpm typecheck, pnpm test, pnpm test:ci. All failed before project validation because this container is missing libsecret-1.so.0, causing uniwind postinstall to fail during pnpm dependency setup.

@kilbot

kilbot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Update on the apps/electron pin sync: the manual bump-submodules.yml dispatch failed — the Protect main ruleset rejected the bot's direct push to main (GH013: Repository rule violations). So the monorepo main/v1.9.6 apps/electron pin stays at aab0ecf (electron 1.9.5 commit, behind by the version-bump commit). This is reference-only and does not affect the published desktop assets — electron v1.9.6 is published for all platforms, built from the electron repo's own package.json (1.9.6). Follow-up: the bump-submodules bot needs a ruleset bypass actor to auto-sync submodule pins (it currently fails every run), or a small PR can bump the pin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant